Merge pull request #54 from stphnpt/0.x

Check for a valid object in `BlockAdmin::toString`

Admin/BlockAdmin.php

@@ -229,9 +229,7 @@ public function getPersistentParameters()
             $parameters['composer'] = $composer;
         }
 
-        if ($composer = $this->getRequest()->get('type')) {
-            $parameters['type'] = $composer;
-        }
+        $parameters['type'] = $this->getRequest()->get('type');
 
         return $parameters;
     }
@@ -243,7 +241,14 @@ public function getPersistentParameters()
      */
     public function toString($object)
     {
-        return $object->getName();
+        if (!is_object($object)) {
+            return '';
+        }
+        if (method_exists($object, 'getName') && null !== $object->getName()) {
+            return (string) $object->getName();
+        }
+
+        return parent::toString($object);
     }
 
     /**

Tests/Admin/BlockAdminTest.php

@@ -0,0 +1,59 @@
+<?php
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\DashboardBundle\Tests\Admin;
+
+use Sonata\AdminBundle\Admin\Admin;
+use Sonata\DashboardBundle\Admin\BlockAdmin;
+use Sonata\DashboardBundle\Tests\Fixtures\Entity\FooGetName;
+use Sonata\DashboardBundle\Tests\Fixtures\Entity\FooGetNameNull;
+use Sonata\DashboardBundle\Tests\Fixtures\Entity\FooNoGetName;
+use Symfony\Component\HttpFoundation\Request;
+
+/**
+ * BlockAdminTest.
+ *
+ * @author Stéphane Paté <[email protected]>
+ */
+final class BlockAdminTest extends \PHPUnit_Framework_TestCase
+{
+    public function testToString()
+    {
+        $admin = new BlockAdmin(
+            'sonata.dashboard.admin.block',
+            'DashboardBundle\Entity\BaseBlock',
+            'SonataDashboardBundle:BlockAdmin'
+        );
+
+        $s = new FooGetName();
+        $this->assertSame('GetName', $admin->toString($s));
+
+        $s = new FooGetNameNull();
+        $this->assertSame('GetNameNull', $admin->toString($s));
+
+        $s = new FooNoGetName();
+        $this->assertSame('NoGetName', $admin->toString($s));
+    }
+
+    public function testGetPersistentParameters()
+    {
+        $admin = new BlockAdmin(
+            'sonata.dashboard.admin.block',
+            'DashboardBundle\Entity\BaseBlock',
+            'SonataDashboardBundle:BlockAdmin'
+        );
+
+        $request = new Request();
+        $admin->setRequest($request);
+
+        $this->assertArrayHasKey('type', $admin->getPersistentParameters());
+    }
+}

Tests/Fixtures/Entity/FooGetName.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Sonata\DashboardBundle\Tests\Fixtures\Entity;
+
+final class FooGetName
+{
+    public function getName()
+    {
+        return 'GetName';
+    }
+}

Tests/Fixtures/Entity/FooGetNameNull.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Sonata\DashboardBundle\Tests\Fixtures\Entity;
+
+final class FooGetNameNull
+{
+    public function getName()
+    {
+        return;
+    }
+
+    public function __toString()
+    {
+        return 'GetNameNull';
+    }
+}

Tests/Fixtures/Entity/FooNoGetName.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Sonata\DashboardBundle\Tests\Fixtures\Entity;
+
+final class FooNoGetName
+{
+    public function __toString()
+    {
+        return 'NoGetName';
+    }
+}