fix: active state in side menu for nested child admins #8163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastnloud
force-pushed
the
fix-admin-voter
branch
from
91ca394
to
2e76fed
Compare
fastnloud
force-pushed
the
fix-admin-voter
branch
from
2e76fed
to
07f9b8d
Compare
|
Thanks, I refactored and added tests in #8173 |
Awesome and no probs! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: active state in side menu
I am targeting this branch, because this fix applies to 4.x which is the default branch.
This fix will make sure the parent admin will maintain its active state in the side menu when navigating through multiple nested child admins.
Changelog