-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete attr support #8083
Autocomplete attr support #8083
Conversation
Hi @pietaj, can you fix the Documentation build ? |
bfd483e
to
c532bb9
Compare
src/Resources/views/Form/Type/sonata_type_model_autocomplete.html.twig
Outdated
Show resolved
Hide resolved
c532bb9
to
6ce3078
Compare
@phansys thx for the cosmetic review, I've pushed an update to that. Anyway, I see that the tests fail on phpstan. Should I do sth about it in the scope of this PR? |
Not needed in this PR I would say, but if you want to fix it in other PR this would be awesome |
Subject
I am targeting this branch, because Sonata 4 does not support the attr option in ModelAutocompleteType
Sonata3 ModelAutocompleteType rendered the passed attr options into the autocomplete template allowing for custom data attributes etc. This was removed here: 8f4d466 which I think was simply overlooked
Moreover Select2 v4 no longer supports readonly, see: https://github.com/select2/select2/blob/4.0.13/CHANGELOG.md
Changelog