Upgrade to font awesome 5 #7133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new package name for font awesome and also add a compatibility layer with version 4, because we have a lot of icons placed around all Sonata bundles and packages
31 tasks
VincentLanglet
approved these changes
Apr 29, 2021
The bc layer was the trigger to me too |
core23
approved these changes
Apr 29, 2021
|
Thansk @jordisala1991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC break on 3.x.
Part of #7049
I Upgraded to font awesome 5, but keeping a compatibility layer with version 4. On this bundle I have replaced all icons with its new version, but other sonata bundles will still use the old icon names until upgraded, this ensure it will still work.
Followed this guide: https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4
And check the icon exist here: https://fontawesome.com/icons?d=gallery&p=2
I just used the 'fas' and 'fab' prefix, because thats the only "free" part, rest of icons are paid (there are some far that are not paid but not used them)
Changelog