Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for issue with German version #77

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Patch for issue with German version #77

wants to merge 10 commits into from

Conversation

mr-late
Copy link
Collaborator

@mr-late mr-late commented Jun 29, 2016

This should fix the issues that are mentioned in #76

@mr-late mr-late changed the title Patch for issue #76 Patch for issue with German version Jun 29, 2016
@somini
Copy link
Owner

somini commented Jun 29, 2016

Can you rebase this to the latest master? What is the actual commit that fixes the issue?
This introduces loads of commits that were already merged.

If you're not sure how to do it, I can sort it out myself, but it will take a while.

@mr-late
Copy link
Collaborator Author

mr-late commented Jul 1, 2016

Yeah sorry about that, still a newbie with Github. The changed files are 'about_version.tga' 'Change Log.txt' and 'screenshotmanager.layout'

commit codes are 3abfc2b, 4c5430a, a024883

@somini
Copy link
Owner

somini commented Jul 2, 2016

I've merged your commits (branch pull/77), but I got the upload and delete button aligned on top.
screenshot from 2016-07-02 19 40 58
I tried to put some align="bottom-right" on the screenshotmanager file, but it didn't work.

@mr-late
Copy link
Collaborator Author

mr-late commented Jul 2, 2016

Crap, I got it fixed now, for real.

Line 321 should look like: place { control="null_placer" region="details" width=-1 align=bottom-left margin-bottom=5 }
322: place { control="spoiler_checkbox" start="null_placer" region="details" align=bottom margin-bottom=30 margin-right=7 spacing=5 }
323: place { control="delete_button,details_button,publish_button" start="null_placer" region="details" align=right x=5 margin-bottom=9 margin-right=1 margin-top=312 spacing=5 }

This was a quick and ugly hack though, so it might bite in the ass later.

@somini
Copy link
Owner

somini commented Jul 2, 2016

Yup, it only works for the smallest possible window size, if you resize the windows the buttons stay put.
I aligned to the bottom and try to center it. It's basically impossible to fix it this way, since there's two different sizes, whether the screenshot is uploaded or not. It's better if we try to solve it in some other way, but it seems that align="bottom-right" is bugged.

I pushed my changes (and yours) to the pull/77 branch, please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants