Merge pull request openwebwork#2603 from dlglin/CheckboxPermissionLevels

Fix checkboxes for permission levels on Config page
somiaj · Oct 18, 2024 · 6d96fda · 6d96fda
2 parents 193ff38 + a7d4652
commit 6d96fda
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/WeBWorK/ConfigObject/permission_checkboxlist.pm b/lib/WeBWorK/ConfigObject/permission_checkboxlist.pm
@@ -52,8 +52,9 @@ sub comparison_value ($self, $val) {
 }
 
 sub entry_widget ($self, $default, $is_secret = 0) {
-	my $c = $self->{c};
-	$default = role_and_above($self->{c}->ce->{userRoles}, $default) unless ref($default) eq 'ARRAY';
+	my $c         = $self->{c};
+	my $userRoles = $self->{c}->ce->{userRoles};
+	$default = role_and_above($userRoles, $default) unless ref($default) eq 'ARRAY';
 	return $c->c(
 		map {
 			$c->tag(
@@ -72,7 +73,7 @@ sub entry_widget ($self, $default, $is_secret = 0) {
 					)->join('')
 				)
 			)
-		} ('guest', 'student', 'login_proctor', 'grade_proctor', 'ta', 'professor', 'admin')
+		} grep { $_ ne 'nobody' } sort { $userRoles->{$a} <=> $userRoles->{$b} } keys(%$userRoles)
 	)->join('');
 }