Log reader now doesn't choke on negative lines

solspace · Oct 4, 2018 · a70411c · a70411c
1 parent 24e414d
commit a70411c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Loggers/Readers/LineLogReader.php b/src/Loggers/Readers/LineLogReader.php
@@ -80,8 +80,10 @@ public function getLastLines(int $numberOfLines = self::DEFAULT_NUMBER_OF_LINES)
             if ($line) {
                 $lines[] = $line;
             }
-            $currentKey--;
-            $this->file->seek($currentKey);
+
+            if (--$currentKey >= 0) {
+                $this->file->seek($currentKey);
+            }
 
             if (\count($lines) >= $numberOfLines) {
                 break;

diff --git a/tests/Loggers/LineLogReaderTest.php b/tests/Loggers/LineLogReaderTest.php
@@ -39,6 +39,11 @@ public function testReadsLastThreeLines()
         $this->assertCount(3, $this->logReader->getLastLines(3));
     }
 
+    public function testAskingMoreLinesReturnsMaximum()
+    {
+        $this->assertCount(5, $this->logReader->getLastLines(20));
+    }
+
     public function testDefaultParser()
     {
         list($lineA, $lineB, $lineC, $lineD) = $this->logReader->getLastLines(4);