Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFT-1608]: Write integration for Form Monitor #1686

Open
wants to merge 22 commits into
base: v5
Choose a base branch
from

Conversation

gustavs-gutmanis
Copy link
Contributor

@gustavs-gutmanis gustavs-gutmanis commented Dec 13, 2024

Related Ticket Number

SFT-1608

Description

Integrating Form Monitor into Freeform

@gustavs-gutmanis gustavs-gutmanis self-assigned this Dec 13, 2024
@gustavs-gutmanis gustavs-gutmanis added the feature Makes this a feature label Dec 13, 2024
useSidebarSelect(5);

const { data: forms, isFetching: isFetchingForms } = useQueryFormsWithStats();
const { data: formIds, isFetching: isFetchingFormids } = useFMForms();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isFetchingFormids --> isFetchingFormIds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not liking the use of FM instead of FormMonitor throughout the API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pointers, I'll change them

seandelaney
seandelaney previously approved these changes Dec 16, 2024
Copy link
Contributor

@seandelaney seandelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far functionality is all working. No issues adding new Form Monitor integration to existing forms.

…feat/SFT-1608-form-monitor

# Conflicts:
#	packages/plugin/src/Resources/js/client/client.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Makes this a feature
Development

Successfully merging this pull request may close these issues.

3 participants