-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SFT-1608]: Write integration for Form Monitor #1686
base: v5
Are you sure you want to change the base?
Conversation
… feat/SFT-1608-form-monitor
useSidebarSelect(5); | ||
|
||
const { data: forms, isFetching: isFetchingForms } = useQueryFormsWithStats(); | ||
const { data: formIds, isFetching: isFetchingFormids } = useFMForms(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isFetchingFormids
--> isFetchingFormIds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not liking the use of FM
instead of FormMonitor
throughout the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pointers, I'll change them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far functionality is all working. No issues adding new Form Monitor integration to existing forms.
…feat/SFT-1608-form-monitor # Conflicts: # packages/plugin/src/Resources/js/client/client.js
…feat/SFT-1608-form-monitor
Related Ticket Number
SFT-1608
Description
Integrating Form Monitor into Freeform