Skip to content

Commit

Permalink
Log into GCR before pushing docs image (#160)
Browse files Browse the repository at this point in the history
* Log into GCR before pushing docs image
* Add changelog
* Move changelog to latest version
  • Loading branch information
Sodman authored Aug 17, 2020
1 parent 740262b commit 45deeb3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,20 @@ jobs:
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- name: Login to gcloud registry
id: gcloud
uses: elgohr/[email protected]
with:
account_key: ${{ secrets.GCLOUD_KEY }}
- name: Release
if: github.event.release.tag_name
env:
KUBECTL: ${{ steps.kubectl.outputs.kubectl-path }}
QUAY_IO_PASSWORD: ${{ secrets.QUAY_IO_PASSWORD }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAGGED_VERSION: ${{ github.event.release.tag_name }}
GCR_USERNAME: ${{ steps.gcloud.outputs.username }}
GCR_PASSWORD: ${{ steps.gcloud.outputs.password }}
run: |
docker login quay.io --username "solo-io+solobot" --password $QUAY_IO_PASSWORD
make install-deps build-images operator-gen manifest-gen publish-images upload-github-release-assets publish-docs
3 changes: 3 additions & 0 deletions changelog/v0.0.26/docs-publish.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog:
- type: NON_USER_FACING
description: CI/CD login to gcloud before trying to push docs image to GCR
1 change: 1 addition & 0 deletions docs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ SERVE_AS_LATEST_TAG:=$(VERSION)-latest
## don't bother generating manifest, just copy/modify from docs-prod repo
# docker-push-docs: site-release manifest
docker-push-docs: site-release
@echo "${GCR_PASSWORD}" | docker login -u ${GCR_USERNAME} --password-stdin gcr.io
docker build \
--build-arg VERSION=latest \
--build-arg PRODUCT_SCOPE=$(PRODUCT_SCOPE) \
Expand Down

0 comments on commit 45deeb3

Please sign in to comment.