[1.18] bump istio, go-control-plane and k8s 1.32 deps (#10611) #10627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
Sodman
reviewed
Feb 17, 2025
Comment on lines
-604
to
-605
| Describe("when opencensus provider config", func() { | ||
| It("translates the plugin correctly using OcagentAddress", func() { |
There was a problem hiding this comment.
Did we intentionally delete this test?
There was a problem hiding this comment.
Yes. Open Census support has been deprecated in Envoy for a long time, and they finally removed the protos from go-control-plane.
Sodman
reviewed
Feb 17, 2025
There was a problem hiding this comment.
PR LGTM! However, since we're doing a major go-control-plane, istio and k8s dep bumps, and this is being released in a patch release, we'll want to trigger extended tests for this build to have more confidence that we're not breaking any existing customers pulling in a patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #10611