Ruby deps fix #508
Merged
Ruby deps fix #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipts and instructions. Gets Docker dev setup running again.
|
I know the docker setup will work with this change, but there's a .ruby-version file which still declares the version to be 2.7.3, should that be changed as well? And what about vagrant? makeitso.sh also has version 2.7.3 specified. I tried and at least the docker version still works if I change the .ruby-version to 3.1.3 (and the Dockerfile ruby version 3.1 -> 3.1.3) |
added 2 commits
January 9, 2024 10:30
…e deps pre-3.x but make bundler old enough too
| @@ -273,6 +273,7 @@ PLATFORMS | |||
| DEPENDENCIES | |||
| compass | |||
| github-pages | |||
| webrick | |||
There was a problem hiding this comment.
Where is this needed?
There was a problem hiding this comment.
Seems to work. Resolved.
petteripoyhtari
approved these changes
Jan 9, 2024
petteripoyhtari
approved these changes
Jan 9, 2024
tatut
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets Docker setup running again.