Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code #47

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Clean up code #47

merged 2 commits into from
Jun 18, 2024

Conversation

solita-antti-mottonen
Copy link
Collaborator

Idea's automatic formatting removes necessary imports if it cannot resolve used constructor. Added necessary type hints, and ran automatic formatting.

Idea's automatic formatting removes necessary imports if it cannot
resolve used constructor. Added necessary type hints, and ran automatic
formatting.
Copy link
Contributor

@Juholei Juholei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laita tässäkin typehintit mieluummin jo siihen missä asia määritellään, eli parametrilistaan tai letiin, jos vain onnistuu.

@solita-antti-mottonen
Copy link
Collaborator Author

Laita tässäkin typehintit mieluummin jo siihen missä asia määritellään, eli parametrilistaan tai letiin, jos vain onnistuu.

Onnistuu, mutta rupesin miettimään miten olisi suoraan funktion paluuarvolle read-pdf:ään? Kumpi on idiomaattisempi tapa?

@Juholei
Copy link
Contributor

Juholei commented Jun 14, 2024

Kyllä senkin pitäisi toimia ja jos tuntuu järkevältä niin tee vain niin.

@solita-antti-mottonen solita-antti-mottonen merged commit 436a66a into master Jun 18, 2024
9 checks passed
@solita-antti-mottonen solita-antti-mottonen deleted the cleanup-code branch June 18, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants