Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create_profile to use Stripe gem #81

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from

Conversation

brchristian
Copy link
Contributor

@brchristian brchristian commented Aug 15, 2020

This PR is a replacement / extension for the work in #77. It can commit cleanly if #77 is merged, or alternately #77 can be closed and this PR can take its place.

Changes from #77:

I’m very pleased with this result.

@spaghetticode Your code review of #77 was amazing, and I incorporated all of your suggestions there into this PR as well. What do you think?

@brchristian brchristian changed the title Refactor create_profile to use Stripe gem Refactor create_profile to use Stripe gem Aug 15, 2020
@brchristian brchristian force-pushed the stripe_gem_create_profile branch 3 times, most recently from 3acf921 to 77f2b5f Compare August 16, 2020 18:30
@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2022
@gsmendoza gsmendoza removed the stale label Nov 11, 2022
@elia elia added the v4.x Issues and PRs targeting the classic frontend (before v5) label Nov 29, 2022
@elia elia changed the base branch from master to v4 December 20, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4.x Issues and PRs targeting the classic frontend (before v5)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants