Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow stripe connect options when create intent #121

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from

Conversation

ccarruitero
Copy link
Contributor

This PR is sponsored by MagmaLabs

This allow solidus_stripe gem to use stripe connect.

Stripe connect allows you to split payment, so you can take a fee from there. The main use for these feature is for marketplaces or platforms.

This implement the stripe connect with direct or destination charges.

I'm not totally sure where will be the best place to set the connected_account in the gem. This will be the account where stripe transfer the payment less the fee.
For now I set that in payment method, but maybe will be better left that part to the application implementation.

Let me know what do you think?

@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2022
@gsmendoza gsmendoza removed the stale label Nov 11, 2022
@elia elia added the v4.x Issues and PRs targeting the classic frontend (before v5) label Nov 29, 2022
@elia elia changed the base branch from master to v4 December 20, 2022 10:26
@ericgross
Copy link

ericgross commented Feb 29, 2024

@elia @ccarruitero I am interested in using this (or a similar) enhancement to collect connect payments. I'm curious if you are using this in production and if you might have made any changes since pushing this up.

Is this something that could be merged or is it waiting on anything? I can try to help if there is anything that's needed.

Thanks again for all this work.

@ccarruitero
Copy link
Contributor Author

Hi @ericgross

I was looking into stripe connect docs and I think the intent options for connect is still the same

But solidus_stripe gem changed a bit since this PR was opened. Right now this PR is not compatible with latest version.

Looking into solidus_stripe, it already handle additional parameters when create intent. So, if you want to reimplement this, you only need to add the logic for connect options in the gateway authorize method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4.x Issues and PRs targeting the classic frontend (before v5)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants