Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More generator updates #198

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

More generator updates #198

wants to merge 10 commits into from

Conversation

elia
Copy link
Member

@elia elia commented Dec 20, 2022

Summary

Those changes are sourced from adjustments done on individual extensions.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

elia added 10 commits December 20, 2022 12:52
@elia
Setup dummy app ENV vars before requiring core support files
398962d
@elia
Streamline the proposed CircleCI configuration
b4197c2 
- only install chrome, which is the default driver
- stop using sqlite-memory
- add a sqlite based job
- test against different ruby version (with minimal redundancy)
@elia
Streamline bin/sandbox
4153af5 
- shadow the bundle command and make it run "with unbundled env"
- shed support for the legacy `with_clean_env`
- use local bundle config instead of the deprecated inline flags
- generalize support for extensions installed by `solidus:install`
- thinner layer between env variables and `rails new` options
- mark the main operation to ease debugging issues
@elia
Support for Bundler.with_unbundled_env is now common
f5119d0
@elia
Use the #sh helper in the spec to add debugging support
9943690
@elia
Initialize the extension dir with git
0d48252
@elia
Use bundle add --path to setup the sandbox
f92a4ac 
Require a version of bundler that supports `--path` in the `add`
command.
@elia
Use an absolute path when adding dev-support to the gemfile
d0095f7
@elia
Skip solidus_bolt when creating the dummy app
cf334f4 
We need to skip solidus bolt for Solidus v3.2, otherwise it will try
to install it when creating the dummy app.
@elia
elia/updates: [wip]
f7c8fbd
@elia elia self-assigned this Dec 20, 2022
@mergify mergify bot added the needs changelog label Needs a label to determine the type of change. label Dec 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2022

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elia elia

Labels
needs changelog label Needs a label to determine the type of change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elia