Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixUpdate return_reasons.rb #5901

Merged
merged 1 commit into from
Nov 8, 2024
Merged

FixUpdate return_reasons.rb #5901

merged 1 commit into from
Nov 8, 2024

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Nov 7, 2024

Summary

Extending return_reasons.rb with additional return reasons.

Fixes #5900

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (439904c) to head (fe2eb38).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5901   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files         783      783           
  Lines       17994    17994           
=======================================
  Hits        16113    16113           
  Misses       1881     1881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthobe fthobe marked this pull request as ready for review November 7, 2024 18:19
@fthobe fthobe requested a review from a team as a code owner November 7, 2024 18:19
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent to merging this since stores can add whatever reasons make sense for their particular situation, but these seem broad enough to be valid defaults. Approved.

@tvdeyen
Copy link
Member

tvdeyen commented Nov 8, 2024

Yeah. Better than current values tbh.

@tvdeyen tvdeyen merged commit f16b59d into solidusio:main Nov 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Return Reasons with Warranty Claim
3 participants