Legacy Promotions: Move ransackable promo associations from core #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
|
Note: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5893 +/- ##
==========================================
- Coverage 89.58% 87.88% -1.71%
==========================================
Files 783 477 -306
Lines 17989 11657 -6332
==========================================
- Hits 16116 10245 -5871
+ Misses 1873 1412 -461 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Oct 31, 2024
adammathys
approved these changes
Nov 1, 2024
kennyadsl
approved these changes
Nov 1, 2024
`Spree::Order#promotions` and `Spree::Order#order_promotions` are now only defined in the `legacy_promotions` gem. Thus they should not be safelisted as ransackable in core.
tvdeyen
force-pushed
the
legacy-promotions-ransackable-associations
branch
from
39b3ece
to
58b6d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves the safelisting of
promotionsandorder_promotionsas ransackable associations out ofsolidus_coreintosolidus_legacy_promotions.Spree::Order#promotionsandSpree::Order#order_promotionsare now only defined in thelegacy_promotionsgem. Thus they should not be safelisted as ransackable in core.