Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve promotion code batch #5830

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Improve promotion code batch #5830

merged 4 commits into from
Aug 19, 2024

Commits on Aug 16, 2024

  1. Rescue PromotionCode creation 

    Before this fix, when the Spree::PromotionCode creation failed, the
exception was raised and the job fails with error.
This commit rescues the creation exception and remove the failed code
from the codes list.
    @DanielePalombo @kjriga
    DanielePalombo authored and kjriga committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4cc04fb View commit details
    Browse the repository at this point in the history

  2. Add the ability to restart PromotionCode Batch

    @DanielePalombo @kjriga
    DanielePalombo authored and kjriga committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6f6dc4e View commit details
    Browse the repository at this point in the history

  3. Don't use instance variable in spec

    @kjriga
    kjriga committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d7e3688 View commit details
    Browse the repository at this point in the history

  4. Fix performance regression 

    Collecting results of large code counts can exceed available memory.

This was initially proposed on another PR that we are basing this one
on: solidusio#5383

Co-authored-by: Jared Norman <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Benjamin <[email protected]>
Co-authored-by: Sofia <[email protected]>
Co-authored-by: Senem Soy <[email protected]>
Co-authored-by: Andrew Stewart <[email protected]>
Co-authored-by: Chris <[email protected]>
    @kjriga @jarednorman
    @nvandoorn @benjaminwil @sofiabesenski4 @senemsoy @stewart @forkata
    8 people committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    211110a View commit details
    Browse the repository at this point in the history