Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add order shipments component #5514

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Nov 20, 2023

Summary

Current (wip):
Screenshot 2023-11-20 at 12 36 35

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema self-assigned this Nov 20, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/order-show-shipments branch 3 times, most recently from 676e583 to 1bdfbb7 Compare November 22, 2023 10:11
@rainerdema rainerdema added the hold On hold for a reason different from a breaking change label Nov 29, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/order-show-shipments branch 2 times, most recently from 1bcc03e to 44f885b Compare January 11, 2024 16:49
@rainerdema rainerdema force-pushed the rainerd/admin/order-show-shipments branch from 44f885b to 4bdd857 Compare January 25, 2024 15:32
@rainerdema rainerdema force-pushed the rainerd/admin/order-show-shipments branch from 4bdd857 to e1f8c30 Compare February 19, 2024 17:07
spaghetticode and others added 10 commits February 19, 2024 18:32
Since these are already set in all other first-level context blocks
and they're going to change in order to expose a bug in the target
context block, it makes sense to move them there.
Existing specs are reworked and expanded for better coverage and
future improvements.
Increasing the amount of items in the shipment and moving only a
part of them exposes the bug (see the xit spec).
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_admin changelog:solidus_core Changes to the solidus_core gem hold On hold for a reason different from a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants