Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] component instance variables #5254

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jul 17, 2023

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jul 17, 2023
@elia elia requested a review from a team as a code owner July 17, 2023 17:05
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 17, 2023
@elia elia mentioned this pull request Jul 17, 2023
3 tasks
@waiting-for-dev
Copy link
Contributor

@elia, it looks there's a problem on CI

@elia elia marked this pull request as draft July 18, 2023 12:28
@elia elia force-pushed the elia/admin/component-instance-variables branch 4 times, most recently from 34c04d9 to 639c18b Compare July 20, 2023 14:21
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5254 (778466e) into nebulab/admin (778466e) will not change coverage.
The diff coverage is n/a.

❗ Current head 778466e differs from pull request most recent head 16ead9f. Consider uploading reports for the commit 16ead9f to get more accurate results

@@              Coverage Diff               @@
##           nebulab/admin    #5254   +/-   ##
==============================================
  Coverage          88.46%   88.46%           
==============================================
  Files                596      596           
  Lines              14503    14503           
==============================================
  Hits               12830    12830           
  Misses              1673     1673           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia force-pushed the elia/admin/component-instance-variables branch from 639c18b to 16ead9f Compare July 20, 2023 15:46
@elia elia marked this pull request as ready for review July 20, 2023 15:46
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rainerdema rainerdema merged commit 785fd63 into nebulab/admin Jul 21, 2023
@rainerdema rainerdema deleted the elia/admin/component-instance-variables branch July 21, 2023 09:30
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants