Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] ui/toast fix #5250

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[Admin] ui/toast fix #5250

merged 1 commit into from
Jul 14, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jul 14, 2023

Summary

There was a missing .join.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jul 14, 2023
@elia elia requested a review from a team as a code owner July 14, 2023 14:41
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 14, 2023
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #5250 (b1763e7) into nebulab/admin (845a2af) will increase coverage by 0.27%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           nebulab/admin    #5250      +/-   ##
=================================================
+ Coverage          88.38%   88.66%   +0.27%     
=================================================
  Files                593      564      -29     
  Lines              14414    13903     -511     
=================================================
- Hits               12740    12327     -413     
+ Misses              1674     1576      -98     

see 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit cb004d8 into nebulab/admin Jul 14, 2023
@elia elia deleted the elia/admin/ui-toast-fix branch July 14, 2023 15:51
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants