Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safa/restore discounted amount deprecated cop #66

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

safafa
Copy link
Collaborator

@safafa safafa commented Nov 13, 2023

Description

This PR restores solidus/discounted_amount as a warning cop
issue 31


Severity:

  • - info
  • - refactor
  • - convention (default)
  • - warning
  • - error
  • - fatal

Wrong Code

line_item.discounted_amount

Correct Code

line_item.total_before_tax

solidusio/solidus@5d61419


Before submitting the PR make sure the following are checked:

  • The PR relates to only one cop with a clear title and description.
  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran and ensured all tests are passing on a development environment.
  • If this is a new cop, added an entry for the cop on /config/default.yml
  • Updated Changelog

@safafa safafa force-pushed the safa/restore-discounted-amount-deprecated-cop branch 2 times, most recently from 8d150b7 to 5f0196e Compare November 13, 2023 14:17
@safafa safafa force-pushed the safa/restore-discounted-amount-deprecated-cop branch from 5f0196e to d15930d Compare November 24, 2023 17:06
@safafa safafa self-assigned this Nov 24, 2023
@safafa safafa marked this pull request as ready for review November 24, 2023 17:14
@safafa safafa merged commit bd060c7 into main Nov 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants