Add PR Template #38
Add PR Template #38
Conversation
piyushswain
force-pushed
the
piyushswain-add-pr-template
branch
from
a597f3a
to
47ee747
Compare
|
@piyushswain how is going with this Template? 🤔 |
|
What do you think to add a section where we can specify the severity of the COP. |
Yes, we should look at adding a severity level to the PR template. |
piyushswain
force-pushed
the
piyushswain-add-pr-template
branch
2 times, most recently
from
516d0a3
to
62d1bda
Compare
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| * [ ] Squashed related commits together. | ||
| * [ ] Added tests. | ||
| * [ ] Ran and ensured all tests are passing on a development environment. | ||
| * [ ] If this is a new cop, added an entry for the cop on `/config/default.yml` |
There was a problem hiding this comment.
Additionally, for almost every PRs, creating the relative changelog entry as mentioned here will be better.
WDYT of adding another action item here?
There was a problem hiding this comment.
Will add another action item here for the changelog
There was a problem hiding this comment.
After merging #51, it's better to add another action item about updating the documentation running the bundle exec rake task
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| The more detailed you are, the better.** | ||
|
|
||
| ----------------- | ||
| Severity: |
There was a problem hiding this comment.
Is this the intended result? Probably is better to apply the same style as the Before submitting the PR... section
There was a problem hiding this comment.
Hey this is the preview from github's markdown editor
I don't know why the file preview is a bit weird but this one looks fine in the markdown editor
piyushswain
force-pushed
the
piyushswain-add-pr-template
branch
from
62d1bda
to
38baf4b
Compare
This template should contain all required information we want on a cop PR.
piyushswain
force-pushed
the
piyushswain-add-pr-template
branch
from
38baf4b
to
efce3b5
Compare
This PR adds a new PR template for the repository