Skip to content

Commit

Permalink
Merge pull request #47 from solidusio/ml/remove-old-ruby-support
Browse files Browse the repository at this point in the history
Remove support for old Ruby versions
  • Loading branch information
MassimilianoLattanzio authored Jul 28, 2023
2 parents f939bd1 + 32b010c commit 12af424
Show file tree
Hide file tree
Showing 11 changed files with 57 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2' ]
ruby: [ '2.7', '3.0', '3.1', '3.2' ]

steps:
- uses: actions/checkout@v3
Expand All @@ -25,7 +25,7 @@ jobs:
bundler-cache: true
- name: Install dependencies
run: |
gem install bundler -v 2.3.25
gem install bundler
bundle install --jobs 4 --retry 3
- name: Run the default task
run: bundle exec rake
8 changes: 2 additions & 6 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
inherit_from: .rubocop_todo.yml

AllCops:
NewCops: enable
TargetRubyVersion: 2.4

Naming/FileName:
Exclude:
Expand All @@ -16,8 +17,3 @@ Metrics/BlockLength:
Metrics/ClassLength:
Exclude:
- 'tasks/**/*.rb'

# Prevents Ruby 3.1 incompatibility error. You can enable this cop when Ruby 2.4 support is dropped.
# See https://github.com/rubocop/rubocop/issues/10258
Layout/BlockAlignment:
Enabled: false
15 changes: 15 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-07-21 15:08:23 UTC using RuboCop version 1.54.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Severity, Include.
# Include: **/*.gemspec
Gemspec/RequireMFA:
Exclude:
- 'rubocop-solidus.gemspec'
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
## master (unreleased)

## 0.1.3 (2023-07-28)

### New features

* [#47](https://github.com/solidusio/rubocop-solidus/pull/47): Remove support for old versions of ruby. ([@MassimilianoLattanzio][])

### Bug fixes

* [#48](https://github.com/solidusio/rubocop-solidus/pull/48): Fix typos in README and add instructions on how to use the changelog rake task. ([@MassimilianoLattanzio][])

## 0.1.2 (2023-07-14)

### New features

* [#45](https://github.com/nebulab/rubocop-solidus/pull/45): Fix gem version comparison. ([@MassimilianoLattanzio][])
* [#45](https://github.com/solidusio/rubocop-solidus/pull/45): Fix gem version comparison. ([@MassimilianoLattanzio][])

## 0.1.0 (2023-07-10)

Expand Down
24 changes: 14 additions & 10 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
rubocop-solidus (0.1.2)
rubocop-solidus (0.1.3)
rubocop

GEM
Expand All @@ -11,15 +11,17 @@ GEM
bump (0.10.0)
coderay (1.1.3)
diff-lcs (1.5.0)
json (2.6.3)
language_server-protocol (3.17.0.3)
method_source (1.0.0)
parallel (1.20.1)
parallel (1.23.0)
parser (3.2.2.3)
ast (~> 2.4.1)
racc
pry (0.14.2)
coderay (~> 1.1)
method_source (~> 1.0)
racc (1.5.2)
racc (1.7.1)
rainbow (3.1.1)
rake (13.0.6)
regexp_parser (2.8.1)
Expand All @@ -37,17 +39,19 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-support (3.12.1)
rubocop (1.12.1)
rubocop (1.54.2)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.0.0.0)
parser (>= 3.2.2.3)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.2.0, < 2.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.4.1)
parser (>= 2.7.1.5)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
ruby-progressbar (1.13.0)
unicode-display_width (2.4.2)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The type of the changelog correspond to "new feature", "bug-fix" and "changed" e
Here are a few examples:

```markdown
* [#47](https://github.com/solidusio/rubocop-solidus/issues/46): **(Breaking)** Remove support for old Ruby versions. ([@MassimilianoLattanzio][])
* [#46](https://github.com/solidusio/rubocop-solidus/issues/46): **(Breaking)** Remove support for old Ruby versions. ([@MassimilianoLattanzio][])
* [#4](https://github.com/solidusio/rubocop-solidus/pull/4): Update CHANGELOG. ([@piyushswain][])
```

Expand Down
1 change: 0 additions & 1 deletion changelog/fix_typos_in_readme_and_add_instructions.md

This file was deleted.

2 changes: 1 addition & 1 deletion lib/rubocop/solidus/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module RuboCop
module Solidus
VERSION = '0.1.2'
VERSION = '0.1.3'
end
end
2 changes: 1 addition & 1 deletion relnotes/v0.1.2.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
### New features

* [#45](https://github.com/nebulab/rubocop-solidus/pull/45): Fix gem version comparison. ([@MassimilianoLattanzio][])
* [#45](https://github.com/solidusio/rubocop-solidus/pull/45): Fix gem version comparison. ([@MassimilianoLattanzio][])

[@MassimilianoLattanzio]: https://github.com/MassimilianoLattanzio
9 changes: 9 additions & 0 deletions relnotes/v0.1.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
### New features

* [#47](https://github.com/solidusio/rubocop-solidus/pull/47): Remove support for old versions of ruby. ([@MassimilianoLattanzio][])

### Bug fixes

* [#48](https://github.com/solidusio/rubocop-solidus/pull/48): Fix typos in README and add instructions on how to use the changelog rake task. ([@MassimilianoLattanzio][])

[@MassimilianoLattanzio]: https://github.com/MassimilianoLattanzio
2 changes: 1 addition & 1 deletion rubocop-solidus.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
DESCRIPTION
spec.homepage = 'https://www.github.com/solidusio/rubocop-solidus'
spec.license = 'MIT'
spec.required_ruby_version = '>= 2.4.0'
spec.required_ruby_version = '>= 2.7.0'

spec.metadata['homepage_uri'] = spec.homepage
spec.metadata['source_code_uri'] = 'https://www.github.com/solidusio/rubocop-solidus'
Expand Down

0 comments on commit 12af424

Please sign in to comment.