Introducing product brand guidelines #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennyadsl can you take a look? |
3 tasks
|
This looks fantastic! I'll approve once we merge the implementation on Core, thanks @shahmayur001 and @fthobe! |
kennyadsl
requested changes
Dec 7, 2024
| puts product.brand # Outputs the result of your custom logic | ||
| ``` | ||
|
|
||
| [order_adjustments_recalculator]: https://github.com/solidusio/solidus/blob/v3.3/core/app/models/spree/promotion/order_adjustments_recalculator.rb |
There was a problem hiding this comment.
@kennyadsl we will have to put any other changes or contributions on hold till we understand the governance of the repo better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation to guide developers on how to customize the brand selection logic in Solidus. It explains how to configure a custom brand selector class, allowing businesses to define brand logic that suits their needs.
The update helps developers understand how to easily adjust the default behavior without altering core code, giving them more flexibility while keeping everything clear and simple.
Checklist