Flickwerk patches #126
Open
Flickwerk patches #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to be testing whether the login page works for this gem.
This will effectively drop support for Solidus < 4.1, but will enable flickwerk-style patches.
This follows the Flickwerk conventions and should help host apps with lazy loading.
mamhoff
force-pushed
the
flickwerk-patches
branch
from
c3c9c94 to
f894d2a
Compare
We can't just use a class instance variable in a module.
These only need to be loaded if solidus_api and solidus_backend are present. The gem most likely would not work if that's not the case, but with the right amount of massaging one could make it work, and in that case these files should not be autoloaded.
API is not necessarily available, let's protect against non-availability.
mamhoff
force-pushed
the
flickwerk-patches
branch
from
9207f05 to
a57bb65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the patches in this extension to
app/patchesin line with the recommendations set in the Flickwerk Readme