Fix Rails warning about auto-loading Spree::ReviewsConfiguration again #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to have been reverted. When starting a Rails app using Solidus Reviews the following is logged ``` Reloading does not reboot the application, and therefore code executed during initialization does not run again. So, if you reload Spree::ReviewsConfiguration, for example, the expected changes won't be reflected in that stale Class object. ``` This change uses the same styles as solidus_frontend and solidus_backend to load the configuration class.
|
We're getting the same warning. +1 for merging this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a re-submission of PR #98 which appears to have been reverted.
When starting a Rails app using Solidus Reviews the following is logged
This change uses the same styles as solidus_frontend and solidus_backend to load the configuration class.