Fix specs with the latest version of Solidus #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kennyadsl
commented
May 2, 2023
kennyadsl
commented
- There's no more a frontend
- Something changed in how images are saved and now they require access to the database, we can't use build_stubbed anymore in variant specs
- some taxon/taxonomy validations was failing due to Improve Taxon validations and factory solidusio/solidus#4851
jarednorman
approved these changes
May 2, 2023
This was referenced Aug 2, 2023
1. There's no more a frontend 2. Something changed in how images are saved and now they require access to the database, we can't use build_stubbed anymore in variant specs 3. some taxon/taxonomy validations was failing due to solidusio/solidus#4851
jarednorman
previously approved these changes
Aug 2, 2023
|
Any news on this? |
|
Definitely needs some work. |
|
Unfortunately, we are not actively working on this PR anymore, feel free to pick it up and continue the work if you need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.