Skip to content

add new configuration from dom-expressions #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

etodanik
Copy link

This adds new configuration recently added to dom-expressions in the following PR:
ryansolid/dom-expressions#405

Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 3f66907

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@etodanik
Copy link
Author

@ryansolid this allows the use of the new configuration values in vite. I'm not bumping versions in either dom-expressions or here, leaving this to you as you'll probably have to bump the dependency of solid.js itself here.

@etodanik
Copy link
Author

Hey @ryansolid , pinging on this, since this prevents the using of the upstream merged changes in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant