Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: styled tag using dot notation #13

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

RealPeha
Copy link
Contributor

@RealPeha RealPeha commented Jan 13, 2022

Added the ability to call styled.div, the result is the same as styled('div')

@ryansolid ryansolid merged commit c714346 into solidjs:main Feb 18, 2022
@ryansolid
Copy link
Member

Sorry this took so long to get to. Thank you.

@RealPeha
Copy link
Contributor Author

RealPeha commented Feb 18, 2022

I found this webpack plugin authored by goober https://www.npmjs.com/package/babel-plugin-transform-goober. Perhaps its use is more preferable

@ryansolid
Copy link
Member

It is smaller but I'm not going to sweat over like 3 lines of code. If it was larger I'd definitely have more reservations but I think this is fine as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants