fix: return 404 when server function not found

[loetjvr]

fixes #1779

What is the current behavior?

Currently server functions calls are expected to always provide the correct id and name. However in our use case we have had bots that try to access older id and name combinations which results in a 500 error.

What is the new behavior?

This change treats not found server functions with a 404 response so that it provides better logging results in case an older or wrong id is being accessed directly.

[changeset-bot]

⚠️ No Changeset found

Latest commit: cbea1b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	cbea1b8
🔍 Latest deploy log	https://app.netlify.com/sites/solid-start-landing-page/deploys/67a9c4eae9a1660008db4cb8
😎 Deploy Preview	https://deploy-preview-1775--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

More templates

• example-basic
• example-bare
• example-experiments
• example-hackernews
• example-notes
• example-todomvc
• example-with-auth
• example-with-authjs
• example-with-drizzle
• example-with-mdx
• example-with-prisma
• example-with-solid-styled
• example-with-tailwindcss
• example-with-trpc
• example-with-unocss
• example-with-vitest

npm i https://pkg.pr.new/@solidjs/start@1775

commit: cbea1b8

[atilafassina]

Thanks a lot for this PR, @loetjvr
I think it's a great fix to throw a 404 instead of letting a 500 when the server-function name can't be found.

Looking at the code and our compliance tasks, I'd like to ask for a few additional things if you're ok with it:

1. Could you please create an issue describing why this is a problem (you can copy/paste from your PR description where it makes sense) and feel free to @ me if you want.
2. Add to the PR description fixes ### with the issue so our automation can pick up on that
3. I think in DEV mode your error code is perfect, but how about we leave the "server function not found" message out in production? I think it's better for security that we don't offer additional hints on how the system work in this case.
4. Add a changeset with a patch type

Let me know your thoughts if you don't agree.

Cheers 🏆

[loetjvr]

More than happy to make the changes @atilafassina
I did not see any of these requests in the contributions md so was a bit unsure what was required

Also on point number 4, what does this entail? I updated the pr title, should I update somewhere else as well?

[atilafassina]

More than happy to make the changes @atilafassina I did not see any of these requests in the contributions md so was a bit unsure what was required

Also on point number 4, what does this entail? I updated the pr title, should I update somewhere else as well?

That's entirely on us, @loetjvr
we're still improving the process (just merged some important CI tests as requirement)

Now that your PR reached main, I'll make the changes needed on another one.

Thanks a lot for your work!! 🏆