Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: calling server functions without arguments #1329

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix: calling server functions without arguments #1329

merged 2 commits into from
Feb 13, 2024

Conversation

pureliani
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

Server functions throw error if they are called without arguments, please see: #1328

What is the new behavior?

They no longer throw error if called without arguments

Other information

Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: b422f70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
Copy link
Member

Thank you

@ryansolid ryansolid merged commit 95a1e08 into solidjs:main Feb 13, 2024
1 check failed
@pureliani pureliani deleted the fix/server-functions-without-arguments branch February 13, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants