Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization for server functions #1325

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

lxsmnsyc
Copy link
Member

@lxsmnsyc lxsmnsyc commented Feb 12, 2024

Fixes #1323
Fixes #1299

Copy link

changeset-bot bot commented Feb 12, 2024

⚠️ No Changeset found

Latest commit: f0fe994

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
Copy link
Member

ryansolid commented Feb 12, 2024

Ok this was just an optimization to early exit for simple data to not use Serovals format. And we have code on the client side to hopefully sidestep it as well on the deserialization side. I'm a little surprised by this fix, but if it fixes the problem it is fine. I'm probably missing some cases where headers are being used and deserialize stream is being called. I think we can add back optimization later.

@ryansolid ryansolid merged commit fb72196 into main Feb 12, 2024
1 check passed
@lxsmnsyc lxsmnsyc deleted the fix-server-function-serialization branch February 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants