Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edge runtime errors reading formData and jsonData from request body #1282

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

AirBorne04
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently when running solid-start in a edge runtime (cloudflare, netlify, vercel) the posting of data to the _server endpoint and formData to an action causes an error A hanging Promise was canceled (run in wrangler) that is coming from nitro -> nitrojs/nitro#1721

What is the new behavior?

Not causing this error any more

Other information

Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 92e8f8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
Copy link
Member

Thanks.

@ryansolid ryansolid merged commit c4de61d into solidjs:main Jan 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants