Allow passing in routerProps
to <StartClient
#1026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
When embedding a SolidStart app into a larger javascript app, users may need to customize the router source/integration, to avoid messing with the parent/host apps url. Users could use an in-memory based router, a search-param based router, hash-based router, etc.
PR Checklist
There aren't any existing tests for
<StartClient
. I think in the future it would be good to add a "solid-as-a-micro-frontend" example, and we could add a test which ensures that example app renders withsearchParamIntegration
PR Type
What is the current behavior?
Use
patch-package
to pass in routerPropsWhat is the new behavior?
Users can customize router source/integration.
Other information