Skip to content

Commit

Permalink
fix: server function error when using export const (#1803)
Browse files Browse the repository at this point in the history
  • Loading branch information
brenelz authored Feb 13, 2025
1 parent 8649504 commit efd762e
Show file tree
Hide file tree
Showing 7 changed files with 419 additions and 276 deletions.
5 changes: 5 additions & 0 deletions .changeset/cold-scissors-clap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Bump tanstack server functions plugin
2 changes: 1 addition & 1 deletion packages/start/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"dependencies": {
"@vinxi/plugin-directives": "^0.5.0",
"@vinxi/server-components": "^0.5.0",
"@tanstack/server-functions-plugin": "^1.99.5",
"@tanstack/server-functions-plugin": "^1.103.1",
"defu": "^6.1.2",
"error-stack-parser": "^2.1.4",
"html-to-image": "^1.11.11",
Expand Down
4 changes: 4 additions & 0 deletions packages/tests/cypress/e2e/server-function.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ describe("server-function", () => {
cy.visit("/is-server-nested");
cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
});
it("should have isServer true in the server function - const", () => {
cy.visit("/is-server-const");
cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
});
it("should have an id of type string in the server function meta - nested", () => {
cy.visit("/server-function-meta-nested");
cy.get("#server-fn-test").contains('{"serverFnWithMeta":"string"}');
Expand Down
3 changes: 3 additions & 0 deletions packages/tests/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ export default function App() {
<li>
<a href="/is-server-nested">isserver (nested)</a>
</li>
<li>
<a href="/is-server-const">isserver (const)</a>
</li>
<li>
<a href="/is-server-toplevel">isserver (toplevel)</a>
</li>
Expand Down
7 changes: 7 additions & 0 deletions packages/tests/src/functions/use-is-server-const.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
"use server";

import { isServer } from "solid-js/web";

export const serverFnWithIsServer = async () => {
return isServer;
}
19 changes: 19 additions & 0 deletions packages/tests/src/routes/is-server-const.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { createEffect, createSignal } from "solid-js";
import { serverFnWithIsServer } from "~/functions/use-is-server-const";

export default function App() {
const [output, setOutput] = createSignal<{ serverFnWithIsServer?: boolean }>({});


createEffect(async () => {
const restult = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
});


return (
<main>
<span id="server-fn-test">{JSON.stringify(output())}</span>
</main>
);
}
Loading

0 comments on commit efd762e

Please sign in to comment.