Merge branch 'main' into replicate-1801

.github/workflows/close-issue.yml

@@ -0,0 +1,19 @@
+# CronJob
+name: ⏱️ Issue Close Require
+
+on:
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  close-issues:
+    if: github.repository == 'solidjs/solid-start'
+    runs-on: ubuntu-latest
+    steps:
+      - name: needs reproduction
+        uses: actions-cool/issues-helper@v3
+        with:
+          actions: "close-issues"
+          token: ${{ secrets.GITHUB_TOKEN }}
+          labels: "needs reproduction"
+          inactive-day: 3

.github/workflows/compliance.yml

@@ -27,4 +27,4 @@ jobs:
             allcontributors[bot]
             renovate
             renovate[bot]
-          ignore-team-members: false
+          ignore-team-members: true

.github/workflows/issue-labelled.yml

@@ -0,0 +1,30 @@
+name: 🔖 Issue Labelled
+
+on:
+  issues:
+    types: [labeled]
+
+jobs:
+  reply-labeled:
+    if: github.repository == 'vitejs/vite'
+    runs-on: ubuntu-latest
+    steps:
+      - name: contribution welcome
+        if: github.event.label.name == 'contribution welcome' || github.event.label.name == 'help wanted' || github.event.label.name == 'good first issue'
+        uses: actions-cool/issues-helper@v3
+        with:
+          actions: "remove-labels"
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          labels: "pending triage, needs reproduction"
+
+      - name: needs reproduction
+        if: github.event.label.name == 'needs reproduction'
+        uses: actions-cool/issues-helper@v3
+        with:
+          actions: "create-comment, remove-labels"
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            Hello @${{ github.event.issue.user.login }}. Please provide a [minimal reproduction](https://stackoverflow.com/help/minimal-reproducible-example) using a GitHub repository or [StackBlitz](https://stackblitz.com/). Issues marked with `needs reproduction` will be closed if they have no activity within 3 days.
+          labels: "pending triage"

packages/start/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @solidjs/start
 
+## 1.1.1
+
+### Patch Changes
+
+- efd762e: Bump tanstack server functions plugin
+  This fixes `export const` in top-level `"use server"` files.
+  The bundler warning for top-level `"use server"` is still there, but still code-removal works.
+
 ## 1.1.0
 
 ### Minor Changes

packages/start/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solidjs/start",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "type": "module",
   "author": "Ryan Carniato",
   "license": "MIT",

packages/tests/cypress/e2e/server-function.cy.ts

@@ -7,6 +7,10 @@ describe("server-function", () => {
     cy.visit("/is-server-nested");
     cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
   });
+  it("should have isServer true in the server function - const", () => {
+    cy.visit("/is-server-const");
+    cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
+  });
   it("should have an id of type string in the server function meta - nested", () => {
     cy.visit("/server-function-meta-nested");
     cy.get("#server-fn-test").contains('{"serverFnWithMeta":"string"}');

packages/tests/src/app.tsx

@@ -17,6 +17,9 @@ export default function App() {
             <li>
               <a href="/is-server-nested">isserver (nested)</a>
             </li>
+            <li>
+              <a href="/is-server-const">isserver (const)</a>
+            </li>
             <li>
               <a href="/is-server-toplevel">isserver (toplevel)</a>
             </li>

packages/tests/src/functions/use-is-server-const.ts

@@ -0,0 +1,7 @@
+"use server";
+
+import { isServer } from "solid-js/web";
+
+export const serverFnWithIsServer = async () => {
+    return isServer;
+}

packages/tests/src/routes/is-server-const.tsx

@@ -0,0 +1,19 @@
+import { createEffect, createSignal } from "solid-js";
+import { serverFnWithIsServer } from "~/functions/use-is-server-const";
+
+export default function App() {
+    const [output, setOutput] = createSignal<{ serverFnWithIsServer?: boolean }>({});
+
+
+    createEffect(async () => {
+        const restult = await serverFnWithIsServer();
+        setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
+    });
+
+
+    return (
+        <main>
+            <span id="server-fn-test">{JSON.stringify(output())}</span>
+        </main>
+    );
+}