Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct useLocation().query's type from string to object #1056

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

samualtnorman
Copy link
Contributor

@samualtnorman samualtnorman commented Feb 3, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

correct useLocation().query's type from string to object

Copy link

stackblitz bot commented Feb 3, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 4b4442a
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67a624ad1374b900087e8700
😎 Deploy Preview https://deploy-preview-1056--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samualtnorman samualtnorman changed the title correct useLocation().query's type form from string to object correct useLocation().query's type from string to object Feb 4, 2025
Copy link
Collaborator

@amirhhashemi amirhhashemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The exact type is Record<string, string | string[]> but object is sufficient

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) February 7, 2025 18:23
@LadyBluenotes LadyBluenotes merged commit bec3950 into solidjs:main Feb 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants