Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-populate page field when reporting an issue #1051

Merged
merged 43 commits into from
Mar 8, 2025

Conversation

bertday
Copy link
Contributor

@bertday bertday commented Jan 30, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR auto-populates the page field of the GitHub issue template with the current window URL when the user clicks the "Report an issue with this page" link.

Related issues & labels

Copy link

stackblitz bot commented Jan 30, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 1174ada
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67cb9061e4cd4d000888a585

@bertday
Copy link
Contributor Author

bertday commented Jan 30, 2025

Quick note that this might be failing because it depends on/expects #1050 to be merged first. Maybe there was a more elegant way of doing this... 😆 Just let me know if I should rebase or anything like that!

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) January 30, 2025 19:31
Comment on lines 11 to 19
return `https://github.com/solidjs/solid-docs-next/issues/new` +
`?assignees=ladybluenotes` +
`&labels=improve+documentation%2Cpending+review` +
`&projects=` +
`&template=CONTENT.yml` +
`&title=[Content]:` +
`&subject=${getEntryFileName()}` +
`&page=${window.location.href}`
});
Copy link
Collaborator

@amirhhashemi amirhhashemi Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertday A formatting issue is blocking this PR. Could you please format the file or use the following code:

		return (
			"https://github.com/solidjs/solid-docs-next/issues/new" +
			"?assignees=ladybluenotes" +
			"&labels=improve+documentation%2Cpending+review" +
			"&projects=" +
			"&template=CONTENT.yml" +
			"&title=[Content]:" +
			"&subject=${getEntryFileName()}" +
			"&page=${window.location.href}"
		);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amirhhashemi , this should be resolved now!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertday My bad, I should've used ` instead of " for strings. I didn't notice template strings are required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amirhhashemi , just pushed a change to bring this backticks back. Really hoping this does this trick.

auto-merge was automatically disabled February 16, 2025 06:36

Head branch was pushed to by a user without write access

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) February 18, 2025 00:36
auto-merge was automatically disabled February 18, 2025 00:47

Head branch was pushed to by a user without write access

@LadyBluenotes LadyBluenotes merged commit e9fb8de into solidjs:main Mar 8, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: Auto-populate page field when reporting an issue
3 participants