-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auto-populate page field when reporting an issue #1051
Conversation
Also makes the GitHub URL multiline for readabillity. Closes solidjs#1049
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
Quick note that this might be failing because it depends on/expects #1050 to be merged first. Maybe there was a more elegant way of doing this... 😆 Just let me know if I should rebase or anything like that! |
src/ui/page-issue-link.tsx
Outdated
return `https://github.com/solidjs/solid-docs-next/issues/new` + | ||
`?assignees=ladybluenotes` + | ||
`&labels=improve+documentation%2Cpending+review` + | ||
`&projects=` + | ||
`&template=CONTENT.yml` + | ||
`&title=[Content]:` + | ||
`&subject=${getEntryFileName()}` + | ||
`&page=${window.location.href}` | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bertday A formatting issue is blocking this PR. Could you please format the file or use the following code:
return (
"https://github.com/solidjs/solid-docs-next/issues/new" +
"?assignees=ladybluenotes" +
"&labels=improve+documentation%2Cpending+review" +
"&projects=" +
"&template=CONTENT.yml" +
"&title=[Content]:" +
"&subject=${getEntryFileName()}" +
"&page=${window.location.href}"
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amirhhashemi , this should be resolved now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bertday My bad, I should've used ` instead of " for strings. I didn't notice template strings are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amirhhashemi , just pushed a change to bring this backticks back. Really hoping this does this trick.
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Co-authored-by: Amir Hossein Hashemi <[email protected]>
Description(required)
This PR auto-populates the
page
field of the GitHub issue template with the current window URL when the user clicks the "Report an issue with this page" link.Related issues & labels