Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/git artifact linking support #830

Merged
merged 8 commits into from
Aug 21, 2023

Conversation

Alexander-Hjelm
Copy link
Collaborator

@Alexander-Hjelm Alexander-Hjelm commented Aug 19, 2023

@Alexander-Hjelm
Copy link
Collaborator Author

@NWaterbury, I have written the necessary unit tests and additionally made a few changes to ensure compatibility with older config files:

  • the repository-map token in the config.json is not mandatory
  • check if the repository-map token exists when deserializing the config.json. If not, do not add any repos.

Can you please go through my changes and ensure that the tool still functions as you had intended?

@NWaterbury
Copy link
Contributor

Hey @Alexander-Hjelm

Thanks for making those updates! The changes look good to me.

@Alexander-Hjelm
Copy link
Collaborator Author

@NWaterbury Perfect, let me merge after fixing the code smells :)

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Alexander-Hjelm Alexander-Hjelm merged commit c661636 into master Aug 21, 2023
4 checks passed
@Alexander-Hjelm Alexander-Hjelm deleted the feature/git-artifact-linking-support branch August 21, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants