Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Editor’s Draft of the WAC specification #83

Merged
merged 310 commits into from
Jun 30, 2021
Merged

Conversation

csarven
Copy link
Member

@csarven csarven commented Jun 17, 2021

After processing an ocean of documentation, issues, meetings,.. with the goal of coming up with an accurate representation of the WAC specification, this PR includes the initial Editor’s Draft (ED).

Merging this PR will replace the documentation in the README (but move its content to README-v.0.5.0), follow-up on close/respond to all applicable issues, and use the ED as the reference point.

Feedback on errors, inaccuracies, clarifications are welcome. Any request to change features or add extensions to WAC should be followed up in new or existing issues.

After the merge, the Solid Protocol will be updated to remove/update all information related to WAC. A ~Working Draft (WD) PR to the solid/specification repository will follow.

Issues/Discussions referenced:

Edit: Includes response to solid/specification#147 and https://github.com/solid/specification/blob/main/CONTRIBUTING.md#publication-rules

Copy link
Member

@VirginiaBalseiro VirginiaBalseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@matthieubosquet matthieubosquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much work went into that, it's a really nice read, thank you @csarven!

I hope a few of my comments make sense and we can discuss before merging, but regardless of their resolution, I would echo the others that this is a very big step in the right direction and I'm happy to see this on main very soon! :)

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Matthieu Bosquet <[email protected]>
@TallTed
Copy link
Contributor

TallTed commented Jun 29, 2021

This PR is already SO HUGE, it seems long past time to close the door to further review on this PR, merge it, and perform any further review against the main branch (though it may be inspired by review of this PR).

index.html Outdated Show resolved Hide resolved
@TallTed
Copy link
Contributor

TallTed commented Jun 29, 2021

Of course, I've followed on my suggestion to stop accepting suggestions with another suggestion....

csarven and others added 2 commits June 30, 2021 07:51
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@matthieubosquet
Copy link
Member

I think the only point worth addressing remaining in my review is the one about resources without conforming authorization: #83 (comment)

The rest of my points relate to consistent Access Control Resource discovery and I'll try to phrase a relevant issue in this repo shortly.

@csarven
Copy link
Member Author

csarven commented Jun 30, 2021

Thanks everyone for the reviews, feedback, emojis, etc. Merging the PR with no objections. Will follow up on issues/discussions.

Let's take a moment to congrats each other (in our minds) for getting the WAC spec to this point.

So there we have it. It is all sort of simple.

@csarven csarven merged commit da57edf into main Jun 30, 2021
@csarven csarven deleted the editors-draft branch July 7, 2021 07:00
csarven added a commit to solid/specification that referenced this pull request Jul 7, 2021
csarven added a commit to solid/specification that referenced this pull request Jul 7, 2021
csarven added a commit to solid/specification that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants