[WebSocketChannel2023] update example #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use onclose and onmessage as property not method
csarven
reviewed
Sep 1, 2023
| @@ -423,7 +423,7 @@ <h3 property="schema:name">Subscription Example</h3> | |||
| <figure id="websocket-new" class="example listing" rel="schema:hasPart" resource="#websocket-new"> | |||
| <p class="example-h"><span>Example</span>: Establishing a new WebSocket connection.</p> | |||
|
|
|||
| <pre about="#websocket-new" property="schema:description" typeof="fabio:Script"><code>const ws = new WebSocket("wss://websocket.example/?auth=Ys3KiUq", "http://www.w3.org/ns/solid/notifications#WebSocketChannel2023");</code></pre> | |||
| <pre about="#websocket-new" property="schema:description" typeof="fabio:Script"><code>const ws = new WebSocket("wss://websocket.example/?auth=Ys3KiUq");</code></pre> | |||
There was a problem hiding this comment.
Can you please quick remind me why is this no longer necessary?
There was a problem hiding this comment.
I'll double-check it. When I used it with channel type URI as the protocol it was resulting in some error. Simply removing it worked. BTW I think this is only used in a non-normative example, if we want the channel type to rely on it would need to be specified in a normative way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use onclose and onmessage as property not method