-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I167 #171
Closed
I167 #171
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e07775d
Create ignored_entities_model; use it for avoid_unused_parameters & a…
sufftea 410a19f
Add exclude config to the `cyclomatic_complexity` rule
sufftea 27ee066
Implement `exclude` property for the `function_lines_of_code` rule
sufftea 015f105
Added `exclude` property to the `no_empty_block` rule.
sufftea 25c1c77
Added `exclude` configuration to the `number_of_parameters` rule
sufftea 1c321db
better naming
sufftea b457d5a
Edit CHANGELOG
sufftea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 0 additions & 24 deletions
24
lib/src/lints/avoid_returning_widgets/models/avoid_returning_widgets_exclude.dart
This file was deleted.
Oops, something went wrong.
28 changes: 0 additions & 28 deletions
28
lib/src/lints/avoid_returning_widgets/models/avoid_returning_widgets_parameters.dart
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 17 additions & 11 deletions
28
lib/src/lints/cyclomatic_complexity/models/cyclomatic_complexity_parameters.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,25 @@ | ||
/// Cyclomatic complexity metric limits configuration. | ||
import 'package:solid_lints/src/lints/cyclomatic_complexity/models/max_cyclomatic_complexity_parameters.dart'; | ||
import 'package:solid_lints/src/models/ignored_entities_model/ignored_entities_model.dart'; | ||
|
||
/// Config parameters for the `cyclomatic_complexity` rule | ||
class CyclomaticComplexityParameters { | ||
/// Threshold cyclomatic complexity level, exceeding it triggers a warning. | ||
final int maxComplexity; | ||
/// `max_complexity` configuration | ||
final MaxCyclomaticComplexityParameters maxCyclomaticComplexity; | ||
|
||
/// Reference: NIST 500-235 item 2.5 | ||
static const _defaultMaxComplexity = 10; | ||
/// `exclude` configuration | ||
final IgnoredEntitiesModel ignoredEntities; | ||
|
||
/// Constructor for [CyclomaticComplexityParameters] model | ||
const CyclomaticComplexityParameters({ | ||
required this.maxComplexity, | ||
required this.maxCyclomaticComplexity, | ||
required this.ignoredEntities, | ||
}); | ||
|
||
/// Method for creating from json data | ||
factory CyclomaticComplexityParameters.fromJson(Map<String, Object?> json) => | ||
CyclomaticComplexityParameters( | ||
maxComplexity: json['max_complexity'] as int? ?? _defaultMaxComplexity, | ||
); | ||
/// | ||
factory CyclomaticComplexityParameters.fromJson(Map<String, Object?> json) { | ||
return CyclomaticComplexityParameters( | ||
ignoredEntities: IgnoredEntitiesModel.fromJson(json), | ||
maxCyclomaticComplexity: MaxCyclomaticComplexityParameters.fromJson(json), | ||
); | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
lib/src/lints/cyclomatic_complexity/models/max_cyclomatic_complexity_parameters.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/// Cyclomatic complexity metric limits configuration. | ||
class MaxCyclomaticComplexityParameters { | ||
/// Threshold cyclomatic complexity level, exceeding it triggers a warning. | ||
final int maxComplexity; | ||
|
||
/// Reference: NIST 500-235 item 2.5 | ||
static const _defaultMaxComplexity = 10; | ||
|
||
/// Constructor for [MaxCyclomaticComplexityParameters] model | ||
const MaxCyclomaticComplexityParameters({ | ||
required this.maxComplexity, | ||
}); | ||
|
||
/// Method for creating from json data | ||
factory MaxCyclomaticComplexityParameters.fromJson( | ||
Map<String, Object?> json, | ||
) => | ||
MaxCyclomaticComplexityParameters( | ||
maxComplexity: json['max_complexity'] as int? ?? _defaultMaxComplexity, | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think you need to create a separate class for extra params. Just go ahead and inherit this parameters class from the
IgnoredEntitiesModel
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's easier to implement
fromJson
this way. Otherwise: