Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some properties (cursorColor, onTextChange, focusNode, onTextSubmitted, ...) for TextField #83

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Add some properties (cursorColor, onTextChange, focusNode, onTextSubmitted, ...) for TextField #83

merged 5 commits into from
Sep 18, 2024

Conversation

dab246
Copy link
Contributor

@dab246 dab246 commented Jul 24, 2024

Descriptions

  • I want to use some properties of TextField in my project.

@dab246 dab246 force-pushed the twake-supported branch from b1b7af2 to 03f67e3 Compare July 24, 2024 08:15
@illia-romanenko
Copy link
Contributor

Hi @dab246, thanks for the PR!

I just merged one with padding - that looks to be conflicting with yours, could you please solve conflicts and make sure that checks are not failing?

dab246 added 2 commits July 25, 2024 10:20
@dab246 dab246 force-pushed the twake-supported branch from 9a7574a to 4ebe87c Compare July 25, 2024 03:21
@dab246
Copy link
Contributor Author

dab246 commented Jul 25, 2024

Hi @dab246, thanks for the PR!

I just merged one with padding - that looks to be conflicting with yours, could you please solve conflicts and make sure that checks are not failing?

@illia-romanenko Thank your feedback. I rebase it. Please review again help me. Thanks.

@dab246 dab246 force-pushed the twake-supported branch from dc97719 to 68a71c8 Compare July 25, 2024 03:53
illia-romanenko
illia-romanenko requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I added couple of questions - if we can make it simpler/leaner it could be easier to understand.

lib/src/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/src/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
@dab246
Copy link
Contributor Author

dab246 commented Aug 5, 2024

@illia-romanenko Please review again help me. Thanks

@dab246 dab246 requested a review from illia-romanenko August 5, 2024 03:00
@dab246
Copy link
Contributor Author

dab246 commented Sep 18, 2024

@illia-romanenko Did you forget this PR?

illia-romanenko
illia-romanenko approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for delay.
Thanks for your contribution!

@illia-romanenko illia-romanenko merged commit c518eda into solid-software:main Sep 18, 2024
1 check passed
@dab246
Copy link
Contributor Author

dab246 commented Sep 19, 2024

@illia-romanenko I don't see the new version 0.1.1 on pub.dev but the Changelog file has been changed. Please check again. Thanks

Screenshot 2024-09-19 at 12 03 27

@dab246 dab246 mentioned this pull request Sep 19, 2024
Closed
@illia-romanenko
Copy link
Contributor

It should be in 0.1.0 - there is a wrong Changelog on pub. I'll try to fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illia-romanenko illia-romanenko illia-romanenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dab246 @illia-romanenko