-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the _padding value to 8.0; This is because the default 24.0 value… #81
Conversation
… was taking a huge space. I also created a new parameter, "padding" of type: EdgeInsetsGeometry? If this padding is null, we then use the new default 8.0 for all sides.
Hi @SamuelWakoli, thanks for your PR. Could you please fix lints/github actions? |
I commented custom lints, I'm personally unaware why we need it for now.
Hello @illia-romanenko I have commented the following Github Action check: We get this warning, that prevents my PR from passing, although the warning is not related with the PR; I have a feeling that the parameter has a purpose in future; |
I feel like we better remove that parameter then and return lints. |
Alright sir; |
Replaced unused parameter with an underscore in the following GitHub Action check warning: There is an unused parameter in the following file: lib/src/utils/mistake_popup.dart:39:22
What do you think if we change default back to 24? As while changing to 8 might be reasonable, it will introduce breaking change to existing users, probably it doesn't make sense to release it as a breaking change? |
Alright sir; |
Let's consider existing users. then the new parameter will allow new users to update the padding themselves. It totally makes sense sir; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Welcome sir; |
… was taking a huge space.
I also created a new parameter, "padding" of type: EdgeInsetsGeometry? If this padding is null, we then use the new default 8.0 for all sides.