Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 improve verify and test.watch #1759

Merged
merged 13 commits into from
Jan 16, 2025

Conversation

paulovareiro29
Copy link
Contributor

@paulovareiro29 paulovareiro29 commented Jan 7, 2025

Description:

Closes #1758

Definition of Reviewable:

  • relevant tickets are linked

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 25c9d3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🚀 Storybook has been deployed for branch ci_fix-failling-verify-monorepo

smfonseca
smfonseca previously approved these changes Jan 8, 2025
Copy link
Collaborator

@smfonseca smfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulovareiro29 please add an empty changeset. Thanks

@smfonseca smfonseca removed their assignment Jan 8, 2025
@paulovareiro29
Copy link
Contributor Author

If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

@smfonseca I don't believe we need to add empty changesets when we don't want to version bump, however I have added it.

If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

@smfonseca
Copy link
Collaborator

We don't need to add an empty changeset, but from my perspective, it's more of a best practice that all our PRs have a changeset even if it's empty, that way changeset-bot (which is "kind of" a check) is also passing

@karlbaumhauer karlbaumhauer removed their assignment Jan 10, 2025
@mariohamann mariohamann changed the title ci: fix failling verify monorepo chore: 🔧 improve verify and test.watch Jan 13, 2025
@paulovareiro29 paulovareiro29 changed the base branch from next to main January 16, 2025 15:36
@paulovareiro29 paulovareiro29 merged commit 19d0fce into main Jan 16, 2025
12 checks passed
@paulovareiro29 paulovareiro29 deleted the ci/fix-failling-verify-monorepo branch January 16, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

ci: 👷 fix failing verify monorepo and test.watch
5 participants