-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🔧 improve verify and test.watch #1759
Conversation
🦋 Changeset detectedLatest commit: 25c9d3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Storybook has been deployed for branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulovareiro29 please add an empty changeset. Thanks
@smfonseca I don't believe we need to add empty changesets when we don't want to version bump, however I have added it.
|
We don't need to add an empty changeset, but from my perspective, it's more of a best practice that all our PRs have a changeset even if it's empty, that way changeset-bot (which is "kind of" a check) is also passing |
…ix-failling-verify-monorepo
…sign-system/solid into ci/fix-failling-verify-monorepo
Description:
Closes #1758
Definition of Reviewable: