-
Notifications
You must be signed in to change notification settings - Fork 12
Prevent case that login search string is empty #9
base: main
Are you sure you want to change the base?
Conversation
Might prevent a situation like solid-contrib#8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a unit test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be better to error rather than creating an empty object.
Ok, I simply throw an error instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still be great to have a simple unit test for this.
I'm going to add a test case, using |
isn't easy to mock using jest-fetch mock, would you mind I refactor it to node-fetch? |
I think that should be fine @linonetwo |
Might prevent a situation like #8