Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add POST to the ajax request so that larger pedigree upload requests work #5168

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lukasmueller
Copy link
Member

Description

fixes #5167

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

Copy link
Contributor

@chris263 chris263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@ryan-preble
Copy link
Contributor

From what I am reading, the GET protocol sends data as a URL string, which has size limitations. POST encodes data in a JSON, so we should keep this issue in mind whenever sending complex data structures or anything that could get big, since POST will be a safer way of sending the data.

@lukasmueller lukasmueller merged commit 9307e5f into master Oct 28, 2024
4 checks passed
@lukasmueller lukasmueller deleted the topic/fix_pedigree_upload_post branch October 28, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pedigree upload does not work for even not so large pedigrees
3 participants