-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable photo traits with brapi #5162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with sptest and this trait,, it works!
It's outside the scope of this PR I think, but it'd be good to make the variable properties handling more sophisticated. Right now it is possible to add more than one trait format (though only the most recently added is shown in brapi). And the format is not restricted to subset of valid formats, but seems to accept any text input.
Description
Enable photo traits with brapi. Set trait_format to 'photo'.
Also, hide trait properties section for traits; only show for variables. Maybe this section should be renamed...
Checklist
/t/data/fixture/patches/
./docs
has been updated./js
to/js/source/legacy
.