Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable photo traits with brapi #5162

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Conversation

lukasmueller
Copy link
Member

Description

Enable photo traits with brapi. Set trait_format to 'photo'.

Also, hide trait properties section for traits; only show for variables. Maybe this section should be renamed...

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@Sri-2023 Sri-2023 requested review from alockrow and removed request for afpowell October 24, 2024 15:20
Copy link
Member

@bellerbrock bellerbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with sptest and this trait,, it works!

It's outside the scope of this PR I think, but it'd be good to make the variable properties handling more sophisticated. Right now it is possible to add more than one trait format (though only the most recently added is shown in brapi). And the format is not restricted to subset of valid formats, but seems to accept any text input.

@lukasmueller lukasmueller merged commit a463399 into master Oct 24, 2024
4 checks passed
@lukasmueller lukasmueller deleted the topic/enable_brapi_photo_trait branch October 24, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants