Enable creation of empty seedlots

[afpowell]

Description

This PR allows users to create empty seedlots as placeholders (i.e., seedlots with no/zero seed weight values or seed count values), as this seems desirable for certain users.

Closes #5157

Checklist

• Refactoring only
• Documentation only
• Fixture update only
• Bug fix
  • The relevant issue has been closed.
  • Further work is required.
• New feature
  • Relevant tests have been created and run.
  • Data was added to the fixture
    • Data was added via a patch in /t/data/fixture/patches/.
  • User-Facing Change
    • The user manual in /docs has been updated.
  • Any new Perl has been documented using perldoc.
  • Any new JavaScript has been documented using JSDoc.
  • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

[alockrow]

Would it be better to require a weight or count but allow 0s? That way no one accidentally skips those fields without meaning to and there's still a value in one at least one of them.

Or, alternatively, you could give a warning message so that users have to confirm that they want to create a seedlot with no weight and no count.

[ryan-preble]

Would it be better to require a weight or count but allow 0s? That way no one accidentally skips those fields without meaning to and there's still a value in one at least one of them.

Or, alternatively, you could give a warning message so that users have to confirm that they want to create a seedlot with no weight and no count.

I'd say warning message makes the most sense to me. Without knowing who requested this feature I speculate that they want to be able to make a bunch of seedlot entries all at once in anticipation of seed collection and then go back and edit the data once they actually have the seeds collected. Giving a warning popup handles both this case and the case where someone just forgot to enter the data and needs to go back.

[alockrow]

Would it be better to require a weight or count but allow 0s? That way no one accidentally skips those fields without meaning to and there's still a value in one at least one of them.
Or, alternatively, you could give a warning message so that users have to confirm that they want to create a seedlot with no weight and no count.

I'd say warning message makes the most sense to me. Without knowing who requested this feature I speculate that they want to be able to make a bunch of seedlot entries all at once in anticipation of seed collection and then go back and edit the data once they actually have the seeds collected. Giving a warning popup handles both this case and the case where someone just forgot to enter the data and needs to go back.

Sounds good to me!

[lukasmueller]

is the check that the value be numeric still there?

[afpowell]

Yes, the check that a value be numeric should still be there

[lukasmueller]

:-)

[lukasmueller]

Actually, I found an issue: when I added 0 as the count, it appeared as NA in the seedlot later. Shouldn't it appear as 0? May be due to the fact that 0 is also false in Perl...

[alockrow]

Add a warning if the user chooses to make both count and weight empty to make sure that was on purpose.

[alockrow]

There are a couple of issues I'm seeing:

1. If you just put in a space in the count and/or weight fields it will accept it and not throw an error and show up as an NA value in the seedlot. I think we should reject it and give the "a seedlot must have a count or weight" error.
2. As Lukas mentioned above if you put in a 0 it shows up as "NA". I think we want it to show up as a numeric 0.

[afpowell]

Thanks, Amber - I'll check about the spaces and update this PR.

On your other point, after some discussion, we are just going to use this PR to allow the user to create an empty seedlot by using zero values in either the amount or weight fields. Leaving both fields blank is not an option going forward. This will be followed by another ticket/PR that implements the user having to commit to one or the other, and will address the issue of the 0 values actually appearing as 0 values.